Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-45316: [Release][C#] Use GitHub Releases for artifacts #45317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-45316: [Release][C#] Use GitHub Releases for artifacts #45317

wants to merge 1 commit into from

Conversation

kou
Copy link
Member

@kou kou commented Jan 21, 2025 •
edited by github-actions bot
Loading

Rationale for this change

We don't need to use Artifactory for NuGet packages because it's not published to Artifactory.

What changes are included in this PR?

  • Use GitHub Releases for easy to maintain
  • Use .github/workflows/csharp.yml instead of nightly job for easy to maintain

Are these changes tested?

Almost yes.

Are there any user-facing changes?

No.

@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #45316 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 21, 2025
@kou kou force-pushed the release-csharp branch 4 times, most recently from 4c3b685 to 6aaa47d Compare January 21, 2025 08:16
raulcd
raulcd approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kou for taking this effort. I've gone through all these changes and everything looks pretty good to me.
I had some minor questions but have been solved once I've gone through the whole changeset, so from my side this can be merged and tried.
The uploaded contents looks good:

Archive:  nuget.zip
  inflating: Apache.Arrow.20.0.0-dev-10.nupkg  
  inflating: Apache.Arrow.20.0.0-dev-10.nupkg.sha256  
  inflating: Apache.Arrow.20.0.0-dev-10.nupkg.sha512  
  inflating: Apache.Arrow.20.0.0-dev-10.snupkg  
  inflating: Apache.Arrow.20.0.0-dev-10.snupkg.sha256  
  inflating: Apache.Arrow.20.0.0-dev-10.snupkg.sha512  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.nupkg  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.nupkg.sha256  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.nupkg.sha512  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.snupkg  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.snupkg.sha256  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.snupkg.sha512  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.nupkg  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.nupkg.sha256  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.nupkg.sha512  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.snupkg  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.snupkg.sha256  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.snupkg.sha512  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.nupkg  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.nupkg.sha256  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.nupkg.sha512  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.snupkg  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.snupkg.sha256  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.snupkg.sha512  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.nupkg  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.nupkg.sha256  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.nupkg.sha512  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.snupkg  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.snupkg.sha256  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.snupkg.sha512

And the release changes to take those into account look also good.
I've also validated that the verify release script does not require changes (it will verify checksums correctly with the current changes).

.github/workflows/csharp.yml Show resolved Hide resolved
@github-actions github-actions bot added awaiting review Awaiting review awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review awaiting review Awaiting review awaiting merge Awaiting merge labels Jan 21, 2025
@kou
Copy link
Member Author

kou commented Jan 21, 2025

I'm checking tagging cases in my fork...: https://github.com/kou/arrow/releases/tag/apache-arrow-20.0.0-rc0

gh release upload is failing...: https://github.com/kou/arrow/actions/runs/12882744065/job/35921998748#step:11:18

@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jan 21, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 21, 2025
@kou
Copy link
Member Author

kou commented Jan 21, 2025 •
edited
Loading

I confirmed that the followings work well:

@kou
Copy link
Member Author

kou commented Jan 21, 2025

I'll merge this in a few days if nobody objects this.

@assignUser
Copy link
Member

gh release upload is failing...: https://github.com/kou/arrow/actions/runs/12882744065/job/35921998748#step:11:18

The GITHUB_TOKEN needs the contents: write permission to upload releases.

@kou
Copy link
Member Author

kou commented Jan 21, 2025

gh release upload is failing...: https://github.com/kou/arrow/actions/runs/12882744065/job/35921998748#step:11:18

The GITHUB_TOKEN needs the contents: write permission to upload releases.

Right. I've fixed this by it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcd raulcd raulcd approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@jonkeane jonkeane Awaiting requested review from jonkeane jonkeane is a code owner

Assignees
No one assigned
Labels
awaiting change review Awaiting change review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kou @assignUser @raulcd